-
-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Versioning for airflow-operator #725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: We put the generated CRD in the top-level extra directory: extra/crds.yaml because Helm is no longer responsible for rolling out the CRD, the operator is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this change does make regenerate-charts still work as before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can change Makefile, but this will be overwritten by the next templating update. But neither does it make sense to do this globally until all product operators are versioned. I think this is best done as a chore once we reach that stage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this needs to be changed in the Makefile. We did the same thing for the secret-operator, see https://github.com/stackabletech/secret-operator/blob/0dd01ec27c9e53c20af526dbecf7bf034edddbf0/Makefile#L121-L123.
Additionally, the Tiltfile needs to be adjusted to not filter the manifests anymore.
These changes will eventually move into operator-templating, for now any rollouts need to be observed and manually adjusted that these changes are not overridden.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See 3e9f0f8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good. Only thing left is to delete this file.
Description
Warning
WIP: need to re-set to operator-rs version rather than PR branch.
Related to #382.
Tested with stackabletech/operator-rs#1121.
Tip
To test:
stackablectl op in airflow=0.0.0-pr725./scripts/run-tests --skip-operator airflow --test versioningTests 🟢 https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/airflow-operator-it-custom/70/ (Openshift OKD 4.20)
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker