refactor(v3): simplify notifications, translations support#25
Open
Rushaway wants to merge 11 commits intosrcdslab:masterfrom
Open
refactor(v3): simplify notifications, translations support#25Rushaway wants to merge 11 commits intosrcdslab:masterfrom
Rushaway wants to merge 11 commits intosrcdslab:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the notification system in BoostAlert v3.0.0 to use centralized translation phrases, replacing hardcoded messages with a structured localization system. The refactoring consolidates notification logic into dedicated helper functions and adds comprehensive multi-language support for French, Spanish, Russian, and Simplified Chinese in addition to English.
Changes:
- Introduces translation file with 12 phrase keys covering all notification scenarios (knife events, boost events, follow-up infections/kills, and disconnected player cases)
- Refactors notification system into dedicated helper functions (NotifyKnifeEvent, NotifyBoostEvent, NotifyKnifeFollowupConnected, etc.) that use translation keys
- Extracts user ID string building logic into reusable helper functions (BuildUserIdString, BuildStoredUserIdString)
- Removes deagle from boost weapon detection list
- Updates CI/CD workflow to package translations directory
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 17 comments.
| File | Description |
|---|---|
| addons/sourcemod/translations/BoostAlert.phrases.txt | New translation file with 12 phrase keys for 5 languages (EN, FR, ES, RU, CHI) covering all notification scenarios |
| addons/sourcemod/scripting/BoostAlert.sp | Refactored notification system with translation support, extracted helper functions, version bump to 3.0.0, removed deagle weapon |
| README.md | New comprehensive documentation covering features, configuration, notification examples, forwards, and translation support |
| .github/workflows/ci.yml | Updated build workflow to include translations directory in package artifacts |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Updated French translations for knife follow-up messages to correct accents and phrasing.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Rushaway
commented
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.