feat: improve MySQL mathematical expression type inference#4163
Closed
rubensantoniorosa2704 wants to merge 2 commits intosqlc-dev:mainfrom
Closed
feat: improve MySQL mathematical expression type inference#4163rubensantoniorosa2704 wants to merge 2 commits intosqlc-dev:mainfrom
rubensantoniorosa2704 wants to merge 2 commits intosqlc-dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
MySQL mathematical expressions like
(a1 / 1024)were being generated asinterface{}instead of proper types likesql.NullFloat64.Root Cause
IsMathematicalOperatorfunction only supported PostgreSQL operators/to"div"operator, which wasn't recognized"int"for all mathematical operationsSolution
"div"operator support toIsMathematicalOperatorBefore/After