Avoid updating target file mtime in 'generate'#3980
Open
n-oden wants to merge 1 commit intosqlc-dev:mainfrom
Open
Avoid updating target file mtime in 'generate'#3980n-oden wants to merge 1 commit intosqlc-dev:mainfrom
n-oden wants to merge 1 commit intosqlc-dev:mainfrom
Conversation
dosubot
bot
added
size:S
If the target file exists on disk already, compare its contents to the generated source in memory: only update the target file on disk if the contents differ or if the target file is missing. This should allow build tools downstream of sqlc to make conditional decisions based on whether the generated code files have been updated (e.g. mockgen).
n-oden
force-pushed
the
preserve-target-mtime
branch
from
7874bd9 to
916bfbf
Compare
dosubot
bot
added
size:M
Author
|
@kyleconroy small nudge here: is this a change that you're okay with? |
Collaborator
|
Seems like a good idea and pretty cheap to do. I'll hold off on a review until @kyleconroy weighs in. |
Author
|
@kyleconroy gentle ping? :) |
Author
|
@andrewmbenton @kyleconroy Sorry for being a nuisance, but I figured I'd check in once more before the end of the year: is there any chance we can get this merged? (Of course if you have feedback I'm all ears!) |
|
Also curious about this, as I'd like to have my "make build" target generate the sqlc output just like it does for Templ & our Tailwind CSS output.. Currently though, if I use that build target with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the target file exists on disk already, compare its contents to the generated source in memory: only update the target file on disk if the contents differ or if the target file is missing.
This should allow build tools downstream of sqlc to make conditional decisions based on whether the generated code files have been updated (e.g. mockgen).