Fix defaultValue handling for primitive Option parameters#1317
Open
therepanic wants to merge 1 commit intospring-projects:mainfrom
Open
Fix defaultValue handling for primitive Option parameters#1317therepanic wants to merge 1 commit intospring-projects:mainfrom
therepanic wants to merge 1 commit intospring-projects:mainfrom
Conversation
Fixes a case where defaultValue was ignored for primitive option types. Closes: spring-projectsgh-1314 Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
therepanic
commented
Feb 8, 2026
Comment on lines
160
to
-176
| Class<?> parameterType = parameterTypes[i]; | ||
| // check if the option type is primitive or not | ||
| if (!parameterType.isPrimitive()) { | ||
| // try to convert default value if present | ||
| String defaultValue = optionAnnotation.defaultValue(); | ||
| if (!defaultValue.isEmpty()) { | ||
| Object value = this.conversionService.convert(defaultValue, parameterType); | ||
| args.add(value); | ||
| String defaultValue = optionAnnotation.defaultValue(); | ||
| if (!defaultValue.isEmpty()) { | ||
| Object value = this.conversionService.convert(defaultValue, parameterType); | ||
| args.add(value); | ||
| } | ||
| else { | ||
| if (parameterType.isPrimitive()) { | ||
| // for primitive types, add default value of the primitive | ||
| args.add(Utils.getDefaultValueForPrimitiveType(parameterType)); | ||
| } | ||
| else { | ||
| // for non-primitive types, add null | ||
| args.add(null); | ||
| } | ||
| } | ||
| else { | ||
| // for primitive types, add default value of the primitive | ||
| args.add(Utils.getDefaultValueForPrimitiveType(parameterType)); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Currently, we don't use a default value for primitives. I've changed that here, so now we use a default value for both primitives and non-primes and then check whether it's empty or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a case where defaultValue was ignored for primitive option types.
Closes: gh-1314