-
Notifications
You must be signed in to change notification settings - Fork 127
SPL-290972: add connection env for ansible to pick up #1670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/epic_SPL-290563
Are you sure you want to change the base?
Conversation
| } | ||
|
|
||
| // create or update KVService CR with owner reference | ||
| err = ApplyKVServiceCR(ctx, client, cr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably, we can go with createOrUpdate, since we are using the Apply as part of the reconciliation flow.
| // getKVServiceConnectionString returns the connection string for KVService | ||
| func getKVServiceConnectionString(ctx context.Context, client splcommon.ControllerClient, namespace string) string { | ||
| // TODO: | ||
| // wait until the KVService is ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, for now, we can return nil?
|
CLA Assistant Lite bot CLA Assistant Lite bot All contributors have signed the COC ✍️ ✅ |
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
|
I have read the CLA Document and I hereby sign the CLA |
|
I have read the Code of Conduct and I hereby accept the Terms |
Description
What does this PR have in it?
Key Changes
Highlight the updates in specific files
Testing and Verification
Deploy the new operator
Build the splunk image using the private splunk-ansible build
Related Issues
Jira tickets, GitHub issues, Support tickets...
PR Checklist