Draft: migrate events to recorder #1653
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Pull Request Test Coverage Report for Build 20819976977Details
💛 - Coveralls |
Collaborator
Pull Request Test Coverage Report for Build 20914773279Details
💛 - Coveralls |
kasiakoziol
reviewed
Jan 21, 2026
| eventPublisher, _ := newK8EventPublisher(c, cr) | ||
|
|
||
| // Get event publisher from context, create one if not present | ||
| var eventPublisher *K8EventPublisher |
Collaborator
There was a problem hiding this comment.
It could be
eventPublisher, _ = newK8EventPublisher(nil, cr)
if pub := ctx.Value(splcommon.EventPublisherKey); pub != nil {
eventPublisher, _ = pub.(*K8EventPublisher)
}
kasiakoziol
reviewed
Jan 21, 2026
| k8sevent.instance = &cmaster | ||
| k8sevent.Normal(ctx, "", "") | ||
|
|
||
| // Use client to avoid unused variable warning |
Collaborator
There was a problem hiding this comment.
But why do we want to keep it then if it is unused?
kasiakoziol
reviewed
Jan 21, 2026
| scopedLog := reqLogger.WithName("ApplyLicenseMaster") | ||
| eventPublisher, _ := newK8EventPublisher(client, cr) | ||
|
|
||
| // Get event recorder from context |
Collaborator
There was a problem hiding this comment.
We could probably move it to a separate func that could be shared among all files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What does this PR have in it?
Key Changes
Highlight the updates in specific files
Testing and Verification
How did you test these changes? What automated tests are added?
Related Issues
Jira tickets, GitHub issues, Support tickets...
PR Checklist