CSPL-3964: Upgrading operator-sdk

[gabrielm-splunk]

Description

Upgrading operator-sdk to version 1.41.1 and Golang version to 1.24.4. There were some linting changes that trickled through, but were very minor, so just decided to leave in. Thankfully, there weren't any breaking changes, so this was pretty straightforward other than some go mod changes (ran go mod tidy to resolve). This will help resolve security vulnerability: https://splunk.atlassian.net/browse/VULN-42799

Key Changes

The main updates are in the .env and Dockerfile

Testing and Verification

Ran operator locally, installed operator on EKS cluster, and ran unit tests. Added this branch to be picked up by integration testing, so will monitor outputs of that.

Related Issues

• Upgrade operator sdk
• Upgrade golang version
• Security vulnerability scan alert

PR Checklist

• Code changes adhere to the project's coding standards.
• Relevant unit and integration tests are included.
• Documentation has been updated accordingly.
• All tests pass locally.
• The PR description follows the project's guidelines.

[coveralls]

Pull Request Test Coverage Report for Build 21257192131

Details

• 27 of 35 (77.14%) changed or added relevant lines in 14 files are covered.
• 5 unchanged lines in 3 files lost coverage.
• Overall coverage decreased (-0.006%) to 86.357%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/splunk/enterprise/configuration.go	5	6	83.33%
pkg/splunk/enterprise/afwscheduler.go	2	4	50.0%
pkg/splunk/enterprise/indexercluster.go	1	6	16.67%

Files with Coverage Reduction	New Missed Lines	%
pkg/splunk/enterprise/afwscheduler.go	1	92.78%
pkg/splunk/enterprise/indexercluster.go	1	71.33%
pkg/splunk/client/minioclient.go	3	97.81%

Totals
Change from base Build 21235162388:	-0.006%
Covered Lines:	10729
Relevant Lines:	12424

---

💛 - Coveralls

[rlieberman-splunk]

Make sure to remove this line before merging.

[rlieberman-splunk]

Will approve once this is removed. Looks good otherwise!

[kubabuczak]

Why didn't you apply changes listed in Operator SDK upgrade guides?

• version 1.40
• version 1.41

[gabrielm-splunk]

Why didn't you apply changes listed in Operator SDK upgrade guides?

• version 1.40
• version 1.41

@kubabuczak Everything should be addressed within this PR from all migrations. Not everything from those version docs are relevant for us (i.e. webhooks, linting, testing that we already have implementation for, etc) as was pointed out in the prior PR. Is there something specifically you expect to see from these migrations that aren't addressed?

[kubabuczak]

Why didn't you apply changes listed in Operator SDK upgrade guides?

• version 1.40
• version 1.41

@kubabuczak Everything should be addressed within this PR from all migrations. Not everything from those version docs are relevant for us (i.e. webhooks, linting, testing that we already have implementation for, etc) as was pointed out in the prior PR. Is there something specifically you expect to see from these migrations that aren't addressed?

Sure. Can you provide a list of all changes and reasons why they are not included?
Those are the ones that were not applied :

1. Add a devcontainer for Go-based operators
2. Add new GitHub actions for Go-based operators
3. Update your project to properly support TLS certificates for webhooks and metrics server (BTW. while we are not using webhooks now, we are planning to add them)
4. Update your project to properly support TLS for Prometheus scraping
5. Update your project to properly support CA injection for CRDs with conversion webhooks
6. Replace exportloopref with copyloopvar in .golangci.yaml (why we don't have golangci?)
7. Add lint-config target to Makefile to verify linter configuration
8. Upgrade golangci-lint and use v2 config (again, why we don't have golnag ci?)

[gabrielm-splunk]

Why didn't you apply changes listed in Operator SDK upgrade guides?

• version 1.40
• version 1.41

@kubabuczak Everything should be addressed within this PR from all migrations. Not everything from those version docs are relevant for us (i.e. webhooks, linting, testing that we already have implementation for, etc) as was pointed out in the prior PR. Is there something specifically you expect to see from these migrations that aren't addressed?

Sure. Can you provide a list of all changes and reasons why they are not included? Those are the ones that were not applied :

1. Add a devcontainer for Go-based operators
2. Add new GitHub actions for Go-based operators
3. Update your project to properly support TLS certificates for webhooks and metrics server (BTW. while we are not using webhooks now, we are planning to add them)
4. Update your project to properly support TLS for Prometheus scraping
5. Update your project to properly support CA injection for CRDs with conversion webhooks
6. Replace exportloopref with copyloopvar in .golangci.yaml (why we don't have golangci?)
7. Add lint-config target to Makefile to verify linter configuration
8. Upgrade golangci-lint and use v2 config (again, why we don't have golnag ci?)

@kubabuczak most of these concerns were discussed in the previous open PR for this: #1574, but will answer your questions 1 by 1:

1. I don't think we need devcontainer in SOK yet (in previous PR discussed this with Patryk)
2. Same with above
3. We don't use webhooks currently, but this is implemented now
4. This is implemented, now
5. Again, currently we don't use webhooks, so skipped this step
6. From previous PR, opted to exclude the work to add golangci to this project, as when it was added, there were hundreds of files that needed fixing. I added this back in now, but with heavy exclusions (temporarily, while we work down that debt)
7. Same as 6
8. Same as 6

[patrykw-splunk]

@gabrielm-splunk I think we should incorporate webhook and cert related changes here as weel. Especially due to the fact that we're working on the Validation webhook - #1664

[gabrielm-splunk]

@gabrielm-splunk I think we should incorporate webhook and cert related changes here as weel. Especially due to the fact that we're working on the Validation webhook - #1664

@patrykw-splunk this is done

[github-actions]

CLA Assistant Lite bot: All contributors have NOT signed the COC Document

---

I have read the Code of Conduct and I hereby accept the Terms

---

_{You can retrigger this bot by commenting recheck in this Pull Request}

[gabrielm-splunk]

I have read the CLA Document and I hereby sign the CLA

[rlieberman-splunk]

recheck