Update snippet.formitretriever.php#89
Open
bertoost wants to merge 1 commit intosplittingred:developfrom
bertoost:patch-6
Open
Update snippet.formitretriever.php#89bertoost wants to merge 1 commit intosplittingred:developfrom bertoost:patch-6
bertoost wants to merge 1 commit intosplittingred:developfrom
bertoost:patch-6
Conversation
With this change it's possible to have &preHooks on FormItRetriever. This is useful when doing custom loading and keep the nice "redirectToOnNotFound" feature. For example; I want to use the submission form for editting again and I link back to the form with some URL parameters (to identify the item to edit). In my custom preHook I can catch that, gather the fields and populate FormIt dictionairy with that. Normally when I go back to the form with a "FormItRetriever" and &redirectToOnNotFound set, the FormIt store file is no longer there or not valid anymore (storeTime expired). With a custom snippet you can set values and this will make the request valid again. With the if empty around the preHooks call it will make the submission values the most important and overrule the preHook stuff, that's perfect as far I can see.
Contributor
Author
|
Please also add && !$fi->request->hasSubmission() To the new if() statement |
SintezCode
pushed a commit
to SintezCode/FormIt
that referenced
this pull request
Jul 10, 2019
Add fenom to chunk by pdoTools if available
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change it's possible to have &preHooks on FormItRetriever. This is useful when doing custom loading and keep the nice "redirectToOnNotFound" feature.
For example;
I want to use the submission form for editting again and I link back to the form with some URL parameters (to identify the item to edit). In my custom preHook I can catch that, gather the fields and populate FormIt dictionairy with that. Normally when I go back to the form with a "FormItRetriever" and &redirectToOnNotFound set, the FormIt store file is no longer there or not valid anymore (storeTime expired). With a custom snippet you can set values and this will make the request valid again.
With the if empty around the preHooks call it will make the submission values the most important and overrule the preHook stuff, that's perfect as far I can see.