Fix "invalid user_code" error when revoking device auth#2036
Fix "invalid user_code" error when revoking device auth#2036
Conversation
The frontend was incorrectly sending the `DeviceAuthNode`'s `id` to the `/auth/rda/revoke` endpoint instead of the `userCode`, resulting in an "invalid user_code" error. This commit updates `DeviceAuth.tsx` to correctly pass `node.userCode` to `handleRevokeDevice`. Additionally, a comprehensive backend test file (`device_auth_test.go`) has been added to cover `NewRDARevokeHandler` ensuring revocation rules are properly enforced. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 |
Fixes a bug where revoking a device authorization via the UI results in an "invalid user_code" error.
Changes:
tavern/internal/www/src/pages/profile/DeviceAuth.tsxto passnode.userCodeinstead ofnode.idto thehandleRevokeDevicefunction.tavern/internal/http/device_auth_test.goand added a test suite forNewRDARevokeHandlerto ensure the revoke API endpoint functions correctly and handles both admin and normal user authorization constraints.PR created automatically by Jules for task 10053009158567028608 started by @KCarretto