Skip to content

Fix "invalid user_code" error when revoking device auth#2036

Closed
KCarretto wants to merge 1 commit intomainfrom
fix-revoke-device-user-code-10053009158567028608
Closed

Fix "invalid user_code" error when revoking device auth#2036
KCarretto wants to merge 1 commit intomainfrom
fix-revoke-device-user-code-10053009158567028608

Conversation

@KCarretto
Copy link
Copy Markdown
Collaborator

Fixes a bug where revoking a device authorization via the UI results in an "invalid user_code" error.

Changes:

  • Updated tavern/internal/www/src/pages/profile/DeviceAuth.tsx to pass node.userCode instead of node.id to the handleRevokeDevice function.
  • Created tavern/internal/http/device_auth_test.go and added a test suite for NewRDARevokeHandler to ensure the revoke API endpoint functions correctly and handles both admin and normal user authorization constraints.

PR created automatically by Jules for task 10053009158567028608 started by @KCarretto

The frontend was incorrectly sending the `DeviceAuthNode`'s `id` to the `/auth/rda/revoke` endpoint instead of the `userCode`, resulting in an "invalid user_code" error. This commit updates `DeviceAuth.tsx` to correctly pass `node.userCode` to `handleRevokeDevice`.

Additionally, a comprehensive backend test file (`device_auth_test.go`) has been added to cover `NewRDARevokeHandler` ensuring revocation rules are properly enforced.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 6, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2752    ±0 2752    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#1533 2752 2752 0 0 0 0 38.9s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2752 0 0 5.5s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
TestDockerExecutor_Build_ContextCancellation 1 5.5s 5.5s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.2s 5.2s
TestInteractiveShell 1 5.1s 5.1s
TestOtherStreamOutput 1 5.0s 5.0s
imix::bin/imix: install::tests::test_install_execution 3 1.6s 4.7s
imix::bin/imix: install::tests::test_install_execution 3 1.6s 4.7s
imix::bin/imix: install::tests::test_install_execution 3 1.6s 4.7s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

@KCarretto KCarretto closed this Mar 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant