Conversation
Modify `file.list_recent()` to use optional arguments. If not provided, the `path` defaults to `/` and the `limit` defaults to `10`. This makes it simpler to use `file.list_recent()` from the eldritch REPL. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
| pub fn list_recent(path: Option<String>, limit: Option<i64>) -> Result<Vec<String>, String> { | ||
| let mut entries = Vec::new(); | ||
| let root = Path::new(&path); | ||
| let path_str = path.unwrap_or_else(|| "/".to_string()); |
There was a problem hiding this comment.
On windows this should default to the root of the drive
There was a problem hiding this comment.
Added a check to use C:\ as the default path on Windows, and / otherwise.
| // Take limit | ||
| let limit = if limit < 0 { 0 } else { limit as usize }; | ||
| let result = entries.into_iter().take(limit).map(|e| e.path).collect(); | ||
| let limit_usize = if limit_val < 0 { 0 } else { limit_val as usize }; |
There was a problem hiding this comment.
Limit should have a minimum value of 1
There was a problem hiding this comment.
Updated the check to ensure limit is at least 1.
- Use C:\ as default on Windows - Ensure limit is at least 1 Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
1 participant
Modified
implants/lib/eldritch/stdlib/eldritch-libfilecomponents to allowlist_recentmethod to acceptOption<String>andOption<i64>. Default values are/and10respectively. Tests added.PR created automatically by Jules for task 7332547565275857859 started by @KCarretto