feat(shellv2): display host tags in hover tooltip#1987
Conversation
- Updated the `GET_SHELL` GraphQL query to fetch tags associated with a beacon's host. - Updated the `ShellHeader` component to extract these tags from the `shellData` prop. - Modified the host information `Tooltip` in `ShellHeader` to display the tags as a comma-separated list when present. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
This submission adds the host tags to the hover tooltip on the ShellV2 page as requested by the user.
GET_SHELLGraphQL query intavern/internal/www/src/pages/shellv2/graphql.tsto include thetagsfield within thehostquery.ShellHeadercomponent intavern/internal/www/src/pages/shellv2/components/ShellHeader.tsxto read tags from theshellDataprop.Tooltiplabel for the host inShellHeader.tsxto display the tags as a comma-separated list of their names.The changes have been tested with the existing frontend test suite (
vitest), and a Playwright verification script was used to capture a screenshot of the tooltip successfully rendering the tags in a local environment.PR created automatically by Jules for task 3140535286676846987 started by @KCarretto