Skip to content

feat(shellv2): display host tags in hover tooltip#1987

Merged
KCarretto merged 2 commits intomainfrom
feat/shellv2-host-tags-3140535286676846987
Mar 4, 2026
Merged

feat(shellv2): display host tags in hover tooltip#1987
KCarretto merged 2 commits intomainfrom
feat/shellv2-host-tags-3140535286676846987

Conversation

@KCarretto
Copy link
Collaborator

This submission adds the host tags to the hover tooltip on the ShellV2 page as requested by the user.

  1. Updated the GET_SHELL GraphQL query in tavern/internal/www/src/pages/shellv2/graphql.ts to include the tags field within the host query.
  2. Updated the ShellHeader component in tavern/internal/www/src/pages/shellv2/components/ShellHeader.tsx to read tags from the shellData prop.
  3. Added a line to the Tooltip label for the host in ShellHeader.tsx to display the tags as a comma-separated list of their names.

The changes have been tested with the existing frontend test suite (vitest), and a Playwright verification script was used to capture a screenshot of the tooltip successfully rendering the tags in a local environment.


PR created automatically by Jules for task 3140535286676846987 started by @KCarretto

- Updated the `GET_SHELL` GraphQL query to fetch tags associated with a beacon's host.
- Updated the `ShellHeader` component to extract these tags from the `shellData` prop.
- Modified the host information `Tooltip` in `ShellHeader` to display the tags as a comma-separated list when present.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2728    ±0 2728    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#1470 2728 2728 0 0 0 0 43.6s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2728 0 0 5.5s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
TestDockerExecutor_Build_ContextCancellation 1 5.5s 5.5s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.2s 5.2s
TestInteractiveShell 1 5.1s 5.1s
TestOtherStreamOutput 1 5.0s 5.0s
imix::bin/imix: install::tests::test_install_execution 3 1.6s 4.6s
imix::bin/imix: install::tests::test_install_execution 3 1.6s 4.6s
imix::bin/imix: install::tests::test_install_execution 3 1.6s 4.6s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

@KCarretto KCarretto marked this pull request as ready for review March 2, 2026 18:35
@KCarretto KCarretto merged commit 57bea0d into main Mar 4, 2026
8 checks passed
@KCarretto KCarretto deleted the feat/shellv2-host-tags-3140535286676846987 branch March 4, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant