feat(shellv2): Support python f-string syntax highlighting#1973
feat(shellv2): Support python f-string syntax highlighting#1973
Conversation
- Update the regex array in `highlightPythonSyntax` (`shellUtils.ts`) to match `f"..."` and `f'...'` strings separately.
- For matched f-strings, extract inner expressions enclosed in `{}` braces while properly escaping double braces (`{{` and `}}`).
- Recursively apply `highlightPythonSyntax` to the contents of the `{}` braces and color the braces themselves as punctuation.
- Add comprehensive test cases to `shellUtils.test.ts` to verify basic highlighting, nested numbers/expressions, and escaped braces work as expected.
Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This pull request enhances the syntax highlighting utility for
ShellV2(highlightPythonSyntax) by adding support for Python f-strings (f"..."). Previously, f-strings and their inner variable braces were highlighted strictly as literal text.The regular expression rules were updated to capture f-strings explicitly before regular strings. When an f-string is found, it performs a targeted replacement of the
{...}brace expressions, calling the highlighting function recursively on their contents to ensure numbers, variables, and keywords are colored appropriately, while leaving escaped braces ({{ }}) intact. This aligns the shell's feedback with standard Python developer expectations. Included accompanying test suites verify all additions.PR created automatically by Jules for task 12046633296892635630 started by @KCarretto