Fix SQLite table lock errors in tavern integration tests#1949
Fix SQLite table lock errors in tavern integration tests#1949
Conversation
- Added `_busy_timeout=10000` to SQLite DSN in `tavern/internal/http/shell/integration_test.go` and `tavern/internal/portals/integration_test.go` to allow retries on database locks. - Updated `tavern/internal/portals/mux/mux_test.go` to use unique database names per test (`file:ent_%s`) and added busy timeout, preventing cross-test contention. - Applied busy timeout to benchmark tests in `tavern/internal/portals/benchmark_test.go` and `tavern/internal/portals/mux/benchmark_test.go`. These changes resolve flaky test failures caused by "database is locked" errors during concurrent test execution. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 |
1 participant
This change addresses the "table lock" errors causing flaky tests in
tavern/internal/http/shellandtavern/internal/portals. The fix involves adding_busy_timeout=10000to the SQLite connection strings in integration and benchmark tests, allowing the driver to retry when the database is locked. Additionally,tavern/internal/portals/mux/mux_test.gowas updated to use unique in-memory database names for each test case, isolating them and preventing contention.PR created automatically by Jules for task 8258895298285432105 started by @KCarretto