Open
Conversation
- Guard `portable-pty` dependency and usage in `implants/imix` to exclude Solaris. - Implement a stub `run_reverse_shell_pty` for Solaris that returns an error, as PTY support is not available/tested. - Verified that Linux compilation and tests still pass. Co-authored-by: Cictrone <3280309+Cictrone@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Contributor
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
- Split long line in `run_reverse_shell_pty` stub for Solaris to satisfy `cargo fmt`. Co-authored-by: Cictrone <3280309+Cictrone@users.noreply.github.com>
hulto
previously approved these changes
Feb 24, 2026
- Guard `netdev` dependency in `implants/lib/pb/Cargo.toml` to exclude Solaris. - Implement a stub `get_primary_ip` in `implants/lib/pb/src/config.rs` for Solaris. - Verified compilation on Linux. Co-authored-by: Cictrone <3280309+Cictrone@users.noreply.github.com>
- Guard `nix` dependency in `eldritch-libsys` and `eldritch-libfile` to exclude Solaris. - Update `exec_impl.rs` to provide a fallback process spawning mechanism for Solaris without `nix`. - Update `list_impl.rs` to provide fallback owner/group handling for Solaris without `nix`. - Update `timestomp_impl.rs` to disable timestomping on Solaris as it relies on `nix` or unsupported APIs. - Verified compilation and tests on Linux. Co-authored-by: Cictrone <3280309+Cictrone@users.noreply.github.com>
- Update `implants/lib/host_unique/src/file.rs` to include `solaris` in the OS list that uses `/var/tmp/system-id`. - Verified compilation and tests on Linux. Co-authored-by: Cictrone <3280309+Cictrone@users.noreply.github.com>
- Add `link-arg=-lssp` to `[target.x86_64-pc-solaris]` in `implants/.cargo/config.toml` to resolve `__stack_chk_fail` undefined symbol. - Verified compilation and tests on Linux. Co-authored-by: Cictrone <3280309+Cictrone@users.noreply.github.com>
- Implement `get_primary_ip` in `implants/lib/pb/src/config.rs` using `libc::getifaddrs` for Solaris. - Add `libc` dependency for Solaris in `implants/lib/pb/Cargo.toml`. - Remove `netdev` usage for Solaris. - Verified compilation and tests on Linux. Co-authored-by: Cictrone <3280309+Cictrone@users.noreply.github.com>
- Apply `cargo fmt` to fix formatting issues causing CI failure. Co-authored-by: Cictrone <3280309+Cictrone@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables the compilation of the
imiximplant on Solaris by conditionally compilingportable-ptydependent code. Sinceportable-pty(and likely the underlying pty handling) is not confirmed to work on Solaris, the PTY reverse shell functionality is disabled on Solaris (returns an error at runtime). Base functionality should otherwise work.PR created automatically by Jules for task 18137033385668807572 started by @Cictrone