Make WorkBench and Batch Edit transfer checks context aware#7834
Open
acwhite211 wants to merge 2 commits intomainfrom
Open
Make WorkBench and Batch Edit transfer checks context aware#7834acwhite211 wants to merge 2 commits intomainfrom
acwhite211 wants to merge 2 commits intomainfrom
Conversation
Triggered by 04ce005 on branch refs/heads/issue-7810
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7810
Change Ownercould be hidden even when a user had the correct dataset transfer permission, because the UI also depended on unrelatedSpecifyUserread access.This change makes dataset ownership transfer context aware and scoped to the active dataset type. WorkBench datasets use
/workbench/datasettransfer permission. Batch Edit datasets use/batch_edit/datasettransfer permission. Transfer recipients are loaded from a dataset scoped endpoint instead of queryingSpecifyUserdirectly from the front-end.Checklist
self-explanatory (or properly documented)
Testing instructions
RBGE Researcherrole assigned to the test user so the dataset can be opened.WB Transfer (No BE)to the test user.WorkBench > Transferand does not haveBatch Edit > Transfer.Tools.Change Ownerbutton is visible.Change Ownerand verify the dialog opens and the recipient list loads.Tools.Change Owneris not shown for Batch Edit whenBatch Edit > Transferis missing.WB Transfer(or otherwise grantBatch Edit > Transfer) to the same user.Tools.Change Owneris now shown for Batch Edit as well.