Fix resolved loans blocking preparation count updates#7829
Open
acwhite211 wants to merge 1 commit intomainfrom
Open
Fix resolved loans blocking preparation count updates#7829acwhite211 wants to merge 1 commit intomainfrom
acwhite211 wants to merge 1 commit intomainfrom
Conversation
CarolineDenis
approved these changes
Mar 19, 2026
emenslin
approved these changes
Mar 23, 2026
Collaborator
emenslin
left a comment
There was a problem hiding this comment.
- Confirm the save succeeds and the "The preparation is used in a loan." error does not appear.
- Reopen the same preparation and confirm the new count is still
1.
Looks good!
bhumikaguptaa
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #7625
The preparation count validator was counting historical resolved loans as if they were still active. This change updates the front-end check to only block decreases when there is unresolved quantity still on loan.
Checklist
self-explanatory (or properly documented)
Testing instructions
3.3.3items on the loan.3to1.1.