Skip to content

Fix Chronostratigraphy Tree name in new disciplines#7824

Open
alesan99 wants to merge 7 commits intomainfrom
issue-7823
Open

Fix Chronostratigraphy Tree name in new disciplines#7824
alesan99 wants to merge 7 commits intomainfrom
issue-7823

Conversation

@alesan99
Copy link
Contributor

Fixes #7823

When creating a new chronostratigraphy tree with the system configuration tool it would be named "Chronostratigraphy_1".
All new disciplines with chrono trees will now always have them named "Chronostratigraphy", since they are the first and only chrono tree in that discipline.

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add pr to documentation list
  • Add automated tests
  • Add a reverse migration if a migration is present in the PR

Testing instructions

  • Create a new database with a paleo/geo discipline
  • The Chronostratigraphy tree should be called "Chronostratigraphy", with no _1 at the end.
  • Go to System Configuration
  • Create a new paleo/geo discipline
  • Create
  • Switch to the new collection
  • The new Chronostratigraphy tree should be called "Chronostratigraphy", with no _1 at the end.
  • Ensure the tree still works correctly. You should still be able to add nodes to it, edit ranks, etc.

@alesan99 alesan99 added this to the 7.12.0 milestone Mar 18, 2026
@alesan99 alesan99 changed the base branch from main to v7_12_0 March 18, 2026 17:37
@alesan99 alesan99 requested review from a team March 18, 2026 17:44
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The new Chronostratigraphy tree should be called "Chronostratigraphy", with no _1 at the end.
  • Ensure the tree still works correctly. You should still be able to add nodes to it, edit ranks, etc.

When I created the second discipline 2 chronostrat trees were created, the first one was called "Chronostratigraphy" and the second was "Chronostratigraphy_1".

Image

@github-project-automation github-project-automation bot moved this from 📋Back Log to Dev Attention Needed in General Tester Board Mar 18, 2026
@CarolineDenis CarolineDenis modified the milestones: 7.12.0, 7.12.1 Mar 18, 2026
@alesan99 alesan99 requested a review from emenslin March 23, 2026 14:47
@alesan99
Copy link
Contributor Author

alesan99 commented Mar 23, 2026

@emenslin ah I think I found the issue, it should be fixed now 👍
(The last created chronostrat tree was also being assigned to the new collection)

EDIT:

Actually hold off on testing, changing the base messed some stuff up

@alesan99 alesan99 changed the base branch from v7_12_0 to main March 23, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Dev Attention Needed

Development

Successfully merging this pull request may close these issues.

Chronostrat tree is named Chronostratigraphy_1 when creating a second paleo/geo discipline

4 participants