Avoid using deprecated Buffer constructor#5
Open
ChALkeR wants to merge 1 commit intospdy-http2:masterfrom
Open
Avoid using deprecated Buffer constructor#5ChALkeR wants to merge 1 commit intospdy-http2:masterfrom
ChALkeR wants to merge 1 commit intospdy-http2:masterfrom
Conversation
Buffer.concat([]) returns an empty buffer all the way down to 0.8.x. Refs: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
Author
|
2018-02-26 deps list (top 10): |
Author
|
Travis failure is probably unrelated, master is also failing. |
lamweili
approved these changes
Sep 18, 2021
|
@indutny This should be merged as well, to patch all deprecation issues. |
beenotung
added a commit
to beenotung/http-deceiver
that referenced
this pull request
Dec 19, 2022
Buffer() is deprecated due to security and usability issues. It is suggested to use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead. Also discussed in spdy-http2#5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buffer.concat([])returns an empty buffer all the way down to 0.8.x.Alternative way would be to just use
Buffer.alloc(0)and drop support for outdated Node.js versions.Refs:
https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
Tracking: nodejs/node#19079