-frandom-seed: reduce value length#8
Merged
Conversation
The current default `-frandom-seed="$*"` can run into "Argument list too long" errors (E2BIG). This happened in pytorch with 1300 object files on the command line. Fix that by filtering out flags `-*`, object files and libraries. Signed-off-by: Harmen Stoppels <harmenstoppels@gmail.com>
haampie
force-pushed
the
hs/fix/frandom-seed-length
branch
from
4cc9022 to
5334747
Compare
Signed-off-by: Harmen Stoppels <me@harmenstoppels.nl>
kwryankrattiger
approved these changes
May 14, 2026
Collaborator
kwryankrattiger
left a comment
kwryankrattiger
left a comment
There was a problem hiding this comment.
LGTM
The early exit for the frandom seed string loop should be fine. The likely total size of the string, ordering of the args, and likely hood of hitting the early exit for most projects compiling with GCC should avoid too much wasted effort.
Tests look ok.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current default
-frandom-seed="$*"can run into "Argument list toolong" errors (E2BIG). This happened in pytorch with 1300 object files on
the command line.
Fix that by filtering:
-I <path>,-L <path>, and others.What remains is hopefully a short string that contains at a minimum all source files.