Skip to content

add -Werror unit tests #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haampie wants to merge 1 commit into
base: main
Choose a base branch
from
+72 −0
Open

add -Werror unit tests #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 72 additions & 0 deletions test/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1056,6 +1056,77 @@ hello.c')
expect_contains frandom_seed_user_passthrough "$_out" '-frandom-seed=custom'
}

# ---------------------------------------------------------------------------
# -Werror handling
# ---------------------------------------------------------------------------

# _werror_set_mode MODE -> exports KEEP/REPLACE for one of three modes:
# all keep every -Werror* flag
# specific keep -Werror-* and -Werror=*, rewrite bare -Werror to -Wno-error
# none rewrite all -Werror* to -Wno-error*
_werror_set_mode() {
case "$1" in
all)
SPACK_COMPILER_FLAGS_KEEP='-Werror*'
SPACK_COMPILER_FLAGS_REPLACE=''
;;
specific)
SPACK_COMPILER_FLAGS_KEEP='-Werror-*|-Werror=*'
SPACK_COMPILER_FLAGS_REPLACE='-Werror-|-Wno-error= -Werror|-Wno-error'
Copy link
Copy Markdown
Collaborator

@kwryankrattiger kwryankrattiger May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SPACK_COMPILER_FLAGS_REPLACE='-Werror-|-Wno-error= -Werror|-Wno-error'
SPACK_COMPILER_FLAGS_REPLACE='-Werror|-Wno-error'

;;
none)
SPACK_COMPILER_FLAGS_KEEP=''
SPACK_COMPILER_FLAGS_REPLACE='-Werror-|-Wno-error= -Werror|-Wno-error'
;;
esac
export SPACK_COMPILER_FLAGS_KEEP SPACK_COMPILER_FLAGS_REPLACE
}

test_werror_handling() {
wrapper_environment

# Family 1: -Werror / -Werror=specific
_in1='-Werror
-Werror=specific'

_werror_set_mode all
_out=$(dump_args cc "$_in1")
expect_contains werror_all1 "$_out" '-Werror'

_werror_set_mode specific
_out=$(dump_args cc "$_in1")
expect_contains werror_spec1 "$_out" '-Wno-error'
expect_not_contains werror_spec1 "$_out" '-Werror'
Copy link
Copy Markdown
Collaborator

@kwryankrattiger kwryankrattiger May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
expect_not_contains werror_spec1 "$_out" '-Werror'
expect_not_contains werror_spec1 "$_out" '-Werror'
expect_contains werror_none1 "$_out" '-Werror=specific'


_werror_set_mode none
_out=$(dump_args cc "$_in1")
expect_contains werror_none1 "$_out" '-Wno-error'
expect_contains werror_none1 "$_out" '-Wno-error=specific'
expect_not_contains werror_none1 "$_out" '-Werror'
expect_not_contains werror_none1 "$_out" '-Werror=specific'

# Family 2: -Werror-implicit-function-declaration (non-standard dash form)
_in2='-Werror
-Werror-implicit-function-declaration'

_werror_set_mode all
_out=$(dump_args cc "$_in2")
expect_contains werror_all2 "$_out" '-Werror'
Copy link
Copy Markdown
Collaborator

@kwryankrattiger kwryankrattiger May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
expect_contains werror_all2 "$_out" '-Werror'
expect_contains werror_all2 "$_out" '-Werror'
expect_not_contains werror_all2 "$_out" '-Werror-implicit-function-declaration'


_werror_set_mode specific
_out=$(dump_args cc "$_in2")
expect_contains werror_spec2 "$_out" '-Wno-error'
expect_contains werror_spec2 "$_out" '-Werror-implicit-function-declaration'
expect_not_contains werror_spec2 "$_out" '-Werror'

_werror_set_mode none
_out=$(dump_args cc "$_in2")
expect_contains werror_none2 "$_out" '-Wno-error'
expect_contains werror_none2 "$_out" '-Wno-error=implicit-function-declaration'
expect_not_contains werror_none2 "$_out" '-Werror'
expect_not_contains werror_none2 "$_out" '-Werror-implicit-function-declaration'
}

# ---------------------------------------------------------------------------
# Runner
# ---------------------------------------------------------------------------
Expand All @@ -1076,6 +1147,7 @@ test_linker_strips_loopopt
test_spack_managed_dirs_are_prioritized
test_frandom_seed_not_added_without_env
test_frandom_seed_filters_args
test_werror_handling
'

if [ $# -gt 0 ]; then
Expand Down