Fix ZIP-based radius search field visibility#2851
Closed
Arafat-plugins wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Description
This PR fixes an issue with ZIP-based radius search where the radius field could be hidden unexpectedly and the ZIP value was not always preserved on the search result page.
Directorist supports radius search based on ZIP code. When
Radius Searchis configured to work based onZIP, the radius field should appear when a ZIP code is entered and should remain visible when the search result page loads with a ZIP value in the request.Before this change:
zipexisted in the request.After this change:
How to reproduce / How to test
ZIPandRadius Searchfields.Radius Searchto work based onZIP.Before this change:
After this change:
Additional test:
?directory_type=basic&zip=80331&miles=0-98&view=listBefore this change:
After this change:
Regression check:
Any linked issues
Fixes: https://taiga-sovware-u10698.vm.elestio.app/project/directorist/issue/2917
Screenshot
Checklist