Skip to content

Fix shorthand property resolution in typed contexts #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robbieh-noname wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix shorthand property resolution in typed contexts #441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions snapshots/output/syntax/src/object-literals-call-signatures.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,10 @@ export function handleShorthand() {
//^^^^^^^^^^^^^^^^^ reference syntax 1.0.0 src/`object-literals-call-signatures.ts`/consumesInterface().
interfaceMethod,
// ^^^^^^^^^^^^^^^ reference syntax 1.0.0 src/`reusable-types.ts`/Superinterface#interfaceMethod().
// ^^^^^^^^^^^^^^^ reference local 26
property,
// ^^^^^^^^ reference syntax 1.0.0 src/`reusable-types.ts`/Superinterface#property.
// ^^^^^^^^ reference local 23
})
}

21 changes: 21 additions & 0 deletions src/FileIndexer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,27 @@ export class FileIndexer {
break
}
}
// Shorthand properties in typed contexts: also emit local variable reference.
// When getDeclarationsForPropertyAssignment finds type-side declarations,
// isDefinitionNode is false, so handleShorthandPropertyDefinition is never
// called. This block emits the missing local variable reference.
if (
declarations.length > 0 &&
ts.isShorthandPropertyAssignment(node.parent)
) {
const valueSymbol =
this.checker.getShorthandAssignmentValueSymbol(node.parent)
if (valueSymbol) {
for (const decl of valueSymbol.declarations || []) {
const scipSymbol = this.scipSymbol(decl)
if (!scipSymbol.isEmpty()) {
this.pushOccurrence(
new scip.scip.Occurrence({ range, symbol: scipSymbol.value })
)
}
}
}
}
}

/**
Expand Down
Loading