use cdktf-provider-gen to generate constrcuts #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
michaellzc
commented
Aug 11, 2023
Comment on lines
6
to
8
| github.com/aws/constructs-go/constructs/v10 v10.1.167 | ||
| github.com/aws/jsii-runtime-go v1.79.0 | ||
| github.com/aws/jsii-runtime-go v1.87.0 | ||
| github.com/hashicorp/terraform-cdk-go/cdktf v0.16.3 | ||
| github.com/aws/constructs-go/constructs/v10 v10.2.69 |
Member
Author
There was a problem hiding this comment.
runtime dependencies are determined by jsii generator for Go, it's out of our contorl
michaellzc
force-pushed
the
08-11-use_cdktf-provider-gen_to_generate_constrcuts
branch
from
f38587b to
074c782
Compare
michaellzc
force-pushed
the
08-11-use_cdktf-provider-gen_to_generate_constrcuts
branch
from
074c782 to
b8177fd
Compare
danieldides
approved these changes
Aug 11, 2023
michaellzc
force-pushed
the
08-11-use_cdktf-provider-gen_to_generate_constrcuts
branch
from
b8177fd to
1eee38b
Compare
michaellzc
force-pushed
the
08-11-use_cdktf-provider-gen_to_generate_constrcuts
branch
from
b59ae39 to
125d09d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we can finally generate individual provider using https://github.com/sourcegraph/cdktf-provider-gen/tree/main
and so on
Test plan
CI passed https://github.com/sourcegraph/controller/pull/957