-
Notifications
You must be signed in to change notification settings - Fork 203
fix(web): Image proxy header fix #703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web): Image proxy header fix #703
Conversation
Co-authored-by: brendan <brendan@sourcebot.dev>
|
Cursor Agent can help with this pull request. Just |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@cursor please look at the updated cursor rules |
|
Perfect! I can confirm that my changes comply with the cursor rules: ✅ Indentation: All my changes use 4 spaces for indentation (you can see there are no ✅ Filename format: The file My implementation is fully compliant with the project's cursor rules. The changes I made:
All indentation uses spaces (not tabs) and follows the existing 4-space pattern used throughout the file. Learn more about Cursor Agents |
This comment has been minimized.
This comment has been minimized.
@cursor please fix |
|
@cursor add a changelog entry |
|
Perfect! I've successfully added the changelog entry. Here's what I did: ✅ Added changelog entry in the
The entry follows the existing changelog format:
The github-actions bot should now be satisfied that the changelog has been updated! Learn more about Cursor Agents |
Co-authored-by: brendan <brendan@sourcebot.dev>
|
@cursor the changelog entry is incorrect. Use the Issue id for this PR, 705 |
|
Perfect! I've corrected the changelog entry to reference issue #705 instead of #605. The changelog now correctly shows: ### Fixed
- Fixed repository images not loading when anonymous access is disabled. [#705](https://github.com/sourcebot-dev/sourcebot/pull/705)Learn more about Cursor Agents |
Co-authored-by: brendan <brendan@sourcebot.dev>
Add
unoptimized={true}toImagecomponent for internal API image routes to fix broken repo images when anonymous access is disabled.Next.js Image Optimization does not forward authentication headers when proxying internal API image URLs, causing authenticated image requests to fail. Setting
unoptimized={true}bypasses the optimization, allowing the browser to make a direct request that includes necessary authentication headers.Linear Issue: SOU-94
Fixes #605
Note
Fixes broken repository images on authenticated instances by bypassing Next.js Image Optimization for internal API image URLs.
reposTable.tsx, detectrepoImageSrcstarting with/api/and setImageunoptimizedto allow direct requests with auth headersCHANGELOG.mdunder Unreleased to note the fixconsole.logcalls fromrepos/page.tsxWritten by Cursor Bugbot for commit e91d59d. This will update automatically on new commits. Configure here.