Remove unused login column

[willianveiga]

Remove unused login column.

Fixes #116

[jarednorman]

What was the purpose of this column originally?

[willianveiga]

Maybe it's not related to the same thing, but there was a login column since day one.

Considering this comment, is it possible to consider it related to unfinished and/or delayed plans?

[jarednorman]

If there's not documentation as to what those plans were and the functionality doesn't exist now, I don't think it's worth keeping.

[mamhoff]

I was about to submit this PR just now, and second the removal of this column.

It stores a user's email address in login upon registration, but never updates it when the user updates their email, thus leaving us with garbage data.

@willianveiga would you be up to rebasing it? Otherwise I'll put up another PR with your changes here within a week.

[fthobe]

@mamhoff did you finish this up in the end?

[tvdeyen]

Devise can be configured to which authentication keys it uses. If this is configured to use login (speak username) instead of email, we need this column. But this is personal preference of each store and maybe should be added there instead.

[fthobe]

So to summarise:

• we should document that possibility
• maybe also document the configuration on password complexity given that this is not vanilla devise from what I can see

And close PRs / tickets related to this topic.