chore: replace custom inspector/executor builders with mcms helpers#21505
Draft
gustavogama-cll wants to merge 1 commit intodevelopfrom
Draft
chore: replace custom inspector/executor builders with mcms helpers#21505gustavogama-cll wants to merge 1 commit intodevelopfrom
gustavogama-cll wants to merge 1 commit intodevelopfrom
Conversation
product-security-plaid-production
bot
requested review from
ChrisAmora,
bolekk and
ecPablo
Contributor
|
I see you updated files related to
|
Contributor
|
✅ No conflicts with other open PRs targeting |
Contributor
There was a problem hiding this comment.
Pull request overview
Risk Rating: HIGH
This PR bumps the mcms dependency and refactors deployment MCMS test/proposal helpers to use the new mcms/chainwrappers builder helpers, while updating related Go module dependencies across deployment, integration-tests, and system-tests.
Changes:
- Upgrade
github.com/smartcontractkit/mcmstov0.37.0(and bumpchainlink-deployments-frameworktov0.86.1in affected modules). - Replace custom inspector/executor/converter construction with
mcms/chainwrappershelpers + CLDF MCMS adapters indeployment/common/proposalutils. - Update various indirect dependencies (AWS SDK v2, grpc-gateway, gopsutil, testcontainers, OpenTelemetry, gRPC) as a result of the bump.
Reviewed changes
Copilot reviewed 8 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| system-tests/tests/go.mod | Bump CLDF + indirect deps (incl. mcms) for system test module. |
| system-tests/tests/go.sum | Lockfile updates for bumped deps. |
| system-tests/lib/go.mod | Bump CLDF + indirect deps (incl. mcms) for system test lib module. |
| system-tests/lib/go.sum | Lockfile updates for bumped deps. |
| integration-tests/load/go.mod | Bump CLDF + indirect deps (incl. mcms) for load test module. |
| integration-tests/load/go.sum | Lockfile updates for bumped deps. |
| integration-tests/go.mod | Bump mcms/CLDF/testcontainers/grpc for integration-tests module. |
| integration-tests/go.sum | Lockfile updates for bumped deps. |
| deployment/common/proposalutils/mcms_test_helpers.go | Refactor test signing/execution helpers to use mcms/chainwrappers + CLDF adapters. |
| deployment/common/proposalutils/mcms_helpers.go | Refactor inspector building to use mcms/chainwrappers + CLDF adapters; delegate Aptos role mapping helper. |
| deployment/go.mod | Bump mcms + CLDF; adds an mcms replace directive (needs scrutiny). |
| deployment/go.sum | Lockfile updates for bumped deps. |
| core/scripts/go.mod | Bump CLDF + indirect deps (incl. mcms) for scripts module. |
| core/scripts/go.sum | Lockfile updates for bumped deps. |
Requires scrupulous human review:
deployment/common/proposalutils/mcms_test_helpers.go: correctness ofBuildConverters/BuildInspectors/BuildExecutors/BuildTimelockExecutorsusage across EVM/Solana/Aptos and the action passed in (especially for non-schedule actions).deployment/common/proposalutils/mcms_helpers.go: Aptos role/action mapping behavior and error propagation (since this impacts proposal construction in deployment workflows).deployment/go.mod: module replacement semantics and build/CI impact.
Suggested reviewers (per CODEOWNERS):
- For
/deployment/**:@smartcontractkit/operations-platform,@smartcontractkit/ccip-tooling,@smartcontractkit/ccip-offchain,@smartcontractkit/keystone,@smartcontractkit/core - For
/integration-tests/**:@smartcontractkit/devex-tooling,@smartcontractkit/core - General dependency/go-mod changes:
@smartcontractkit/core,@smartcontractkit/foundations
| var err error | ||
| action, err = mcmsaptossdk.ActionFromAptosRole(options.AptosRole) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to get action from aptos role: %s", options.AptosRole.String()) |
There was a problem hiding this comment.
When mcmsaptossdk.ActionFromAptosRole returns an error, the returned error message drops the underlying error context (it doesn't include/%w the err). Wrap the original error so callers can diagnose why the role->action mapping failed.
Suggested change
| return nil, fmt.Errorf("failed to get action from aptos role: %s", options.AptosRole.String()) | |
| return nil, fmt.Errorf("failed to get action from aptos role %s: %w", options.AptosRole.String(), err) |
Bump the mcms library and replace some of the custom inspector/executor/ converter "builder" logic with the "official" helpers recently added to the mcms library.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump the mcms library and replace some of the custom inspector/executor/ converter "builder" logic with the "official" helpers recently added to the mcms library.