Skip to content

Logtrigger ACK System E2E Testing#21495

Draft
DylanTinianov wants to merge 84 commits intodevelopfrom
CRE-2178-e2e-logtrigger-acks
Draft

Logtrigger ACK System E2E Testing#21495
DylanTinianov wants to merge 84 commits intodevelopfrom
CRE-2178-e2e-logtrigger-acks

Conversation

@DylanTinianov
Copy link
Contributor

@DylanTinianov DylanTinianov commented Mar 11, 2026 •
edited
Loading

Extends EVM Log Trigger E2E tests (using local CRE) with ACK system verification via trigger event store persistence.

  • Handles any topology for local / remote trigger capabilities; reads from corresponding wf or capability node DB.
  • Fixes existing bug in EVMLogTriggerTest when multiple evm chains are active. It was looking for the same message from workflows, and skipped the second chain due to stale logs coming from the same Chip sink for reading workflow messages.

Requires

TriggerEventStore LOOP gRPC Server

@DylanTinianov
Add MethodTriggerEventAck
f47800d
@DylanTinianov
Add ackKey
96711cd
@DylanTinianov
Update DON2DON
6d5850a
@DylanTinianov
Merge branch 'develop' of https://github.com/smartcontractkit/chainlink…
e9f89db 
… into PLEX-1460-delivery-acks
@DylanTinianov
Bump common
33bedcb
@DylanTinianov
Add AckEvent
37773c9
@DylanTinianov
Use metadata for acks
58228ff
@DylanTinianov
Merge branch 'develop' of https://github.com/smartcontractkit/chainlink…
5f82379 
… into PLEX-1460-delivery-acks
@DylanTinianov
Bump common
b474420
@DylanTinianov
Generate
603bff5
@DylanTinianov
Bump common
afa3a26
@DylanTinianov
Merge branch 'develop' of https://github.com/smartcontractkit/chainlink…
0ee2696 
… into PLEX-1460-delivery-acks
@DylanTinianov
Bump common
48cd7f2
@DylanTinianov
Update combined_client.go
ff2113d
@DylanTinianov
Fix AckEvent
46b2887
@DylanTinianov
Update
375d76f
@DylanTinianov
Merge branch 'develop' of https://github.com/smartcontractkit/chainlink…
345a2d4 
… into PLEX-1460-delivery-acks
@DylanTinianov
Fix AckEvent
eea15a4
@DylanTinianov
Improve logging
82774a6
@DylanTinianov
Fix AckEvent
8faf3e2
@DylanTinianov
Update fake_trigger.go
76697da
@DylanTinianov
AckEvent
f91717a
@DylanTinianov
Add logging
fa47e9d
@DylanTinianov
Update test logs
079f66c
@DylanTinianov
Add log
a0a0b8a
@DylanTinianov
Update launcher.go
0ac4afa
@DylanTinianov
tests logs
dc7d1d6
@DylanTinianov
Update engine.go
a7424b1
@DylanTinianov
Update engine.go
0d760f7
@DylanTinianov
Test logs
35e4884
@DylanTinianov DylanTinianov changed the title Read DB E2E Logtrigger Testing Mar 11, 2026
@DylanTinianov DylanTinianov changed the base branch from develop to CRE-1738-trigger-event-persistence March 11, 2026 14:07
@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2026 •
edited
Loading

✅ No conflicts with other open PRs targeting develop

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2026

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2026 •
edited
Loading

CORA - Pending Reviewers

Codeowners Entry Overall Num Files Owners
* ⏳ 2 @smartcontractkit/foundations, @smartcontractkit/core
/core/capabilities/ ⏳ 1 @smartcontractkit/keystone, @smartcontractkit/capabilities-team
go.mod ⏳ 6 @smartcontractkit/core, @smartcontractkit/foundations
go.sum ⏳ 6 @smartcontractkit/core, @smartcontractkit/foundations
integration-tests/go.mod ⏳ 1 @smartcontractkit/core, @smartcontractkit/devex-tooling, @smartcontractkit/foundations
integration-tests/go.sum ⏳ 1 @smartcontractkit/core, @smartcontractkit/devex-tooling, @smartcontractkit/foundations

Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown

For more details, see the full review summary.

Base automatically changed from CRE-1738-trigger-event-persistence to develop March 11, 2026 16:46
@trunk-io
Copy link

trunk-io bot commented Mar 11, 2026 •
edited
Loading

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

@DylanTinianov DylanTinianov changed the title E2E Logtrigger Testing E2E Logtrigger ACK System Testing Mar 11, 2026
@cl-sonarqube-production
Copy link

cl-sonarqube-production bot commented Mar 11, 2026

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@DylanTinianov DylanTinianov changed the title E2E Logtrigger ACK System Testing Topology Agnostic Logtrigger ACK System E2E Testing Mar 11, 2026
@DylanTinianov DylanTinianov changed the title Topology Agnostic Logtrigger ACK System E2E Testing Logtrigger ACK System E2E Testing Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@DylanTinianov