Skip to content

[DX-2917] add missing JD image to the CI, use custom nodeset name#21493

Merged
Tofel merged 6 commits intodevelopfrom
dx-2917-cre-soak-test-fix
Mar 12, 2026
Merged

[DX-2917] add missing JD image to the CI, use custom nodeset name#21493
Tofel merged 6 commits intodevelopfrom
dx-2917-cre-soak-test-fix

Conversation

@Tofel
Copy link
Contributor

@Tofel Tofel commented Mar 11, 2026

Couple of bug fixes:

  • added missing JD image to the workflow
  • modified leak detector to work with custom DON names

Successful run: https://github.com/smartcontractkit/chainlink/actions/runs/22967760670/job/66675888690

Memory limit was set to 3.35GB 😬

@github-actions
Copy link
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2026

✅ No conflicts with other open PRs targeting develop

@trunk-io
Copy link

trunk-io bot commented Mar 11, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Risk Rating: MEDIUM (changes affect CI workflow wiring + soak test leak detection thresholds)

Updates CRE soak CI and leak detection to ensure the soak job can pull the Job Distributor image and can find CL nodes when using a custom nodeset/DON name.

Changes:

  • Add explicit CTF_JD_IMAGE to the CRE soak workflow env so the JD image can be pulled in CI.
  • Update CRE soak test leak detection to target a custom nodeset name (workflow) and adjust memory threshold.
  • Bump chainlink-testing-framework (and related indirect deps) across system-test modules and core scripts.

Reviewed changes

Copilot reviewed 5 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
system-tests/tests/soak/cre/soak_test.go Passes a nodeset name into the leak detector and raises memory threshold for CRE runs.
system-tests/tests/go.mod / system-tests/tests/go.sum Bumps chainlink-testing-framework/framework and related indirect deps for system-tests/tests module.
system-tests/lib/go.mod / system-tests/lib/go.sum Mirrors dependency bumps for system-tests/lib module.
core/scripts/go.mod / core/scripts/go.sum Updates chainlink-testing-framework/framework version used by core scripts.
.github/workflows/cre-soak-memory-leak.yml Adjusts runner spec, adds JD image env var, and changes checkout behavior / workflow inputs.

You can also share your feedback on Copilot code review. Take the survey.

mchain0
mchain0 previously approved these changes Mar 12, 2026
skudasov
skudasov previously approved these changes Mar 12, 2026
@cl-sonarqube-production
Copy link

@Tofel Tofel closed this Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants