Skip to content

wave 1.5 error improvements #1839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wentzeld wants to merge 2 commits into
base: main
Choose a base branch
from
Open

wave 1.5 error improvements #1839

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b210f69
wave 1.5 error improvements
wentzeld Feb 15, 2026
def4777
Apply suggestion from @Copilot
wentzeld Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/capabilities/consensus/ocr3/reporting_plugin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,8 @@ func (r *reportingPlugin) Outcome(ctx context.Context, outctx ocr3types.OutcomeC
}

if len(obs) < (2*r.config.F + 1) {
lggr.Debugw("insufficient observations for workflow execution id")
lggr.Warnw("Insufficient observations for workflow execution: consensus skipped because fewer than 2f+1 nodes reported observations",
Copy link
Contributor

@bolekk bolekk Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does't make it more visible in any way.

"observationCount", len(obs), "requiredCount", 2*r.config.F+1)
continue
}

Expand Down
Loading