Skip to content

Simplify ValidateTimestamp using absolute difference #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KodeyThomas merged 1 commit into from
Mar 16, 2026
Merged

Simplify ValidateTimestamp using absolute difference #916

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions protocol/common/hmac/hmac_auth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,13 @@ func ComputeHMAC(secret, stringToSign string) (string, error) {
return hex.EncodeToString(h.Sum(nil)), nil
}

func abs(x int64) int64 {
if x < 0 {
return -x
}
return x
}

// ValidateTimestamp checks if the timestamp is within acceptable window.
func ValidateTimestamp(timestampStr string) error {
timestampMs, err := strconv.ParseInt(timestampStr, 10, 64)
Expand All @@ -148,8 +155,7 @@ func ValidateTimestamp(timestampStr string) error {

now := time.Now().UnixMilli()
diff := now - timestampMs

if diff > DefaultTimeWindow.Milliseconds() || diff < -DefaultTimeWindow.Milliseconds() {
if abs(diff) > DefaultTimeWindow.Milliseconds() {
return fmt.Errorf("timestamp outside acceptable window: %d ms difference", diff)
}

Expand Down
Loading