Aptos local CRE minimal: expose Aptos service APIs and harden TXM submission#380
Open
Aptos local CRE minimal: expose Aptos service APIs and harden TXM submission#380
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
cawthorne
changed the title
cawthorne
force-pushed
the
feature/aptos-local-cre-minimal
branch
from
76474ca to
3a4adef
Compare
Fletch153
previously approved these changes
Mar 10, 2026
ilija42
reviewed
Mar 10, 2026
| if err != nil { | ||
| return nil, err | ||
| } | ||
| if tx == nil { |
Contributor
There was a problem hiding this comment.
Is this similar to how aptos handles txs that are not found? Should this be an error?
|
|
||
| out := &typeaptos.AccountTransactionsReply{Transactions: make([]*typeaptos.Transaction, 0, len(txs))} | ||
| for _, tx := range txs { | ||
| if tx == nil { |
Contributor
There was a problem hiding this comment.
Is it okay to just skip txs, similar question to txByHash
cawthorne
force-pushed
the
feature/aptos-local-cre-minimal
branch
from
1d65259 to
6158e7a
Compare
cawthorne
force-pushed
the
feature/aptos-local-cre-minimal
branch
from
6158e7a to
ba0f696
Compare
cawthorne
force-pushed
the
feature/aptos-local-cre-minimal
branch
from
4abb80d to
c1ca0d7
Compare
yashnevatia
requested changes
Mar 12, 2026
Contributor
yashnevatia
left a comment
yashnevatia
left a comment
There was a problem hiding this comment.
Please rebase once this is merged in
#340
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR upstreams the minimal Aptos work needed to run local CRE read-capability flows, while keeping the patch focused and reviewable.
What changed
Relayer Aptos service surface
Aptos()AccountAPTBalanceLedgerVersionViewTransactionByHashAccountTransactionsChainReader head data support
GetLatestValueWithHeadDatafor Aptos chainreader.Relayer/chain wiring cleanup
KeyStore().GetChainInfo()to use shared chain info helper.Dependency alignment
chainlink-commoncommit on upstreammain.Notes / scope
Viewreads by explicitledger_versionare intentionally not included in this minimal patch and can be reintroduced in a follow-up once dependency stack alignment is complete.Validation
go test ./relayer/...cd integration-tests && go test ./smoke -run '^TestDoesNotExist$' -count=1(compile validation)