feat: add bundle support#4088
Merged
ramonpetgrave64 merged 4 commits intoslsa-framework:mainfrom Feb 12, 2025
ramonpetgrave64:internal-builder-bundle
Merged
feat: add bundle support#4088ramonpetgrave64 merged 4 commits intoslsa-framework:mainfrom ramonpetgrave64:internal-builder-bundle
ramonpetgrave64 merged 4 commits intoslsa-framework:mainfrom
ramonpetgrave64:internal-builder-bundle
Conversation
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
This reverts commit c6b6daf. Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
ramonpetgrave64
requested review from
joshuagl,
kpk47 and
laurentsimon
as code owners
Contributor
Author
Hayden-IO
reviewed
Feb 12, 2025
Collaborator
Hayden-IO
left a comment
Hayden-IO
left a comment
There was a problem hiding this comment.
Are there any code changes from when this PR was last approved?
Contributor
Author
No, only go.mod and go.sum changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Followup up to #3777, #3985, slsa-framework/slsa-verifier#813
Redo: Changes the internal go code to produce Sigstore Bundles, instead of only signed DSSE envelopes. This means that the generic generator and go builder workflows now produce Sigstore Bundles, just like the other BYOB-type workflows.
Testing Process
Tested with a previous commit that contains a debug workflow
pusheventsChecklist