Skip to content

Conversation

@zdomke
Copy link
Contributor

@zdomke zdomke commented Jan 28, 2026

Description

Add a draft state to the Tag Group Dialog that allows users to cancel any pending changes to the group. This prevents any changes to the backend until the user clicks the save button.

Changes kept in a draft state include:

  • Changing the tag group's name or description
  • Adding tags to the group
  • Deleting tags from the group
  • Editing a tag's name or description

Motivation

Closes #24

Where Has This Been Documented?

Waiting on #7

Screenshots

Save button disabled if no changes or no title

Screenshot 2026-01-29 at 16 03 06

Notify users of edits to Tag Group and enable "+ Add" button when applicable

Screenshot 2026-01-29 at 16 10 07

Notify users of edits to tags

Screenshot 2026-01-29 at 16 23 05

Pre-merge checklist

  • Code works interactively
  • Code follows the style guide
  • Code contains descriptive docstrings

@zdomke zdomke self-assigned this Jan 28, 2026
@zdomke
Copy link
Contributor Author

zdomke commented Jan 30, 2026

Just remembered a question I had before. What is the best way to display tags that will be deleted?
Right now it is non-obvious what changes are expected to take place. See example where a tag is pending deletion.

Screenshot 2026-01-29 at 16 40 00

Should I add a separate list of pending deletions under the list of tags?

  • If I do this, should I move added tags & edited tags to their own lists as well?

Should I change the color/tooltip of the "unsaved changes" icon? (red)

  • If I do this should I change the color of the icon for added tags as well? (green)

@zdomke zdomke closed this Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Indicate dirty state on tag group popup

2 participants