-
Notifications
You must be signed in to change notification settings - Fork 677
ci: add build step before publish #2511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2511 +/- ##
=======================================
Coverage 93.17% 93.17%
=======================================
Files 40 40
Lines 11384 11384
Branches 726 726
=======================================
Hits 10607 10607
Misses 765 765
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srtaalej 🤩 The legend oncemore saves the workflows! Blessed thanks!
| - name: Build packages | ||
| run: | | ||
| # Build base dependencies | ||
| npm run build --workspace=@slack/logger | ||
| npm run build --workspace=@slack/types | ||
|
|
||
| # Build packages requiring base dependencies | ||
| npm run build --workspace=@slack/web-api | ||
| npm run build --workspace=@slack/webhook | ||
|
|
||
| # Build packages that depend on the Web API | ||
| npm run build --workspace=@slack/oauth | ||
| npm run build --workspace=@slack/rtm-api | ||
| npm run build --workspace=@slack/socket-mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐ praise: Thanks for fixing this sincere - dependent packages are no joke...
🎁 note: We'll perhaps want to revisit how these are built in scripts but let's let this work in CI as is. The workspaces changes of earlier might be promising!
Summary
This PR adds a build step to
release.ymlto properly package dependencies.Requirements