Skip to content

Conversation

@srtaalej
Copy link
Contributor

Summary

This PR adds a build step to release.yml to properly package dependencies.

Requirements

@srtaalej srtaalej self-assigned this Feb 10, 2026
@srtaalej srtaalej added the dependencies Pull requests that update a dependency file label Feb 10, 2026
@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2026

⚠️ No Changeset found

Latest commit: 92cc9e1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.17%. Comparing base (fe137db) to head (92cc9e1).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2511   +/-   ##
=======================================
  Coverage   93.17%   93.17%           
=======================================
  Files          40       40           
  Lines       11384    11384           
  Branches      726      726           
=======================================
  Hits        10607    10607           
  Misses        765      765           
  Partials       12       12           
Flag Coverage Δ
cli-hooks 95.42% <ø> (ø)
cli-test 94.79% <ø> (ø)
oauth 77.39% <ø> (ø)
socket-mode 61.87% <ø> (ø)
web-api 98.12% <ø> (ø)
webhook 96.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zimeg zimeg added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented github_actions Pull requests that update GitHub Actions code labels Feb 10, 2026
@srtaalej srtaalej marked this pull request as ready for review February 10, 2026 20:57
@srtaalej srtaalej requested a review from a team as a code owner February 10, 2026 20:57
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srtaalej 🤩 The legend oncemore saves the workflows! Blessed thanks!

Comment on lines +68 to +81
- name: Build packages
run: |
# Build base dependencies
npm run build --workspace=@slack/logger
npm run build --workspace=@slack/types

# Build packages requiring base dependencies
npm run build --workspace=@slack/web-api
npm run build --workspace=@slack/webhook

# Build packages that depend on the Web API
npm run build --workspace=@slack/oauth
npm run build --workspace=@slack/rtm-api
npm run build --workspace=@slack/socket-mode
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ praise: Thanks for fixing this sincere - dependent packages are no joke...

🎁 note: We'll perhaps want to revisit how these are built in scripts but let's let this work in CI as is. The workspaces changes of earlier might be promising!

@srtaalej srtaalej merged commit 756d8b9 into main Feb 10, 2026
60 checks passed
@srtaalej srtaalej deleted the f branch February 10, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants