Guard loading against suspicious zip members#515
Closed
massy-o wants to merge 1 commit into
Closed
Conversation
516873c to
96f359c
Compare
adrinjalali
reviewed
May 15, 2026
Member
adrinjalali
left a comment
There was a problem hiding this comment.
Unless there's some common patterns in loading zip files in other libraries which we're replicating here, I wouldn't want to put these limits. This basically means the user can't load large objects, and users might have legit usecases for loading large objects. So I'm not sure if this heurestic is sensible here.
Happy to reopen if there are good arguments for this change, otherwise closing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LoadContextloads()andget_untrusted_types()Tests
uv run --with-editable '.[rich]' --with pytest --with pytest-cov --with flaky --with pandas --with matplotlib pytest skops/io/tests/test_persist.py -k 'compression_ratio or compression_level or sparse_matrix'.skopsartifact check againstload()andget_untrusted_types()Note:
ruff checkon the touched files currently reports an existing E721 issue inskops/io/_general.pyoutside this change.