chore(be): remove unique from nickname#3575
Conversation
There was a problem hiding this comment.
Pull request overview
Removes the uniqueness constraint from the User.nickname field in the backend Prisma schema, allowing multiple users to share the same (non-null) nickname.
Changes:
- Remove
@uniquefromUser.nicknameinschema.prisma. - Add a Prisma migration that drops the existing unique index
user_nickname_keyonpublic.user(nickname).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/backend/prisma/schema.prisma | Removes the @unique attribute from User.nickname. |
| apps/backend/prisma/migrations/20260522111225_remove_unique_constraint_from_nickname/migration.sql | Drops the user_nickname_key unique index to match the schema change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the unique constraint from the nickname field in the User model and includes a database migration to drop the corresponding index. The reviewer noted that allowing duplicate nicknames could lead to impersonation risks and suggested adding a non-unique index if the field is frequently used for searches to maintain performance.
| role Role @default(User) | ||
| jobType JobType @default(CollegeStudent) @map("job_type") | ||
| nickname String? @unique | ||
| nickname String? |
There was a problem hiding this comment.
닉네임의 @unique 제약 조건을 제거하면 중복 사용이 가능해져 사칭(impersonation) 위험이 생길 수 있습니다. UI에서 고유 식별자(예: username)를 병행 표기하는 등의 보완책을 검토해 주세요. 또한, 제약 조건 삭제 시 인덱스도 함께 제거되므로, 해당 필드를 검색에 자주 사용한다면 @@index([nickname]) 추가를 고려해 보시기 바랍니다.
Choi-Jung-Hyeon
left a comment
Choi-Jung-Hyeon
left a comment
There was a problem hiding this comment.
LGTM~! 바로 머지해도 될듯?
Description
nickname 필드 @unique 삭제