Skip to content

feat(fe): redesign main cards#3565

Open
woo943 wants to merge 7 commits into
mainfrom
t2693-redesign-main-cards
Open

feat(fe): redesign main cards#3565
woo943 wants to merge 7 commits into
mainfrom
t2693-redesign-main-cards

Conversation

@woo943
Copy link
Copy Markdown
Contributor

@woo943 woo943 commented May 16, 2026

Description

image
  • service card와 problem card를 새로 디자인 된 대로 구현했습니다.
  • service card에서 contest 탭만 디자인이 나와서 일단 그 부분만 구현했습니다
  • 이후 비슷하게 나온다면 확장 가능하도록 만들었습니다.

Additional context

close TAS-2693


Before submitting the PR, please make sure you do the following

@woo943 woo943 self-assigned this May 16, 2026
@woo943 woo943 requested a review from egg-zz May 16, 2026 15:47
@woo943 woo943 added ⛳️ team-frontend preview 이 라벨이 붙어있어야 프론트엔드 Preview 환경이 생성됩니다 labels May 16, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the UI components for the main landing page, specifically focusing on the problem and service card sections. The NewProblemCard and NewProblemCards components received styling refinements, updated typography, and a simplified navigation link. The ServiceCards component was significantly refactored from a static layout to a dynamic tabbed interface that displays specific features for different services. Review feedback identified several typos in custom CSS class names, the use of an invalid Tailwind utility class, and opportunities to improve responsiveness and user experience by filtering empty tabs and using fluid widths for grid items.

Comment thread apps/frontend/app/(client)/(main)/_components/NewProblemCard.tsx Outdated
Comment thread apps/frontend/app/(client)/(main)/_components/ServiceCards.tsx Outdated
Comment thread apps/frontend/app/(client)/(main)/_components/ServiceCards.tsx Outdated
Comment thread apps/frontend/app/(client)/(main)/_components/ServiceCards.tsx Outdated
@woo943 woo943 requested a review from seoeun9 May 16, 2026 15:48
@skkuding-bot
Copy link
Copy Markdown

skkuding-bot Bot commented May 16, 2026

Syncing Preview App Succeeded

Application: frontend
Revision: 328912c74eca7c6dad85dc1161fad02f1f11cfe1
Health Status: Healthy

Open Preview | View in Argo CD

Copy link
Copy Markdown
Contributor

@seoeun9 seoeun9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~~ 제미나이 리뷰도 한번만 확인 부탁드려요!

<p className="text-3xl font-semibold leading-[36px] tracking-[-0.9px]">
PRACTICE WITH CODING PROBLEMS
</p>
<p className="text-head1_b_40">최신 코딩 문제를 연습해보세요</p>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

이거 일단 급한대로 이전 service 카드 설명을 번역해서 한 카드씩 사용하면 좋을 거 같아요
탭은 주석처리 해주시고

대회 - 대회 개최와 참가를 통해 실력을 겨루고 성장해보세요.
공지사항 - 최신 업데이트와 공지사항을 빠르게 확인할 수 있어요.
문제 풀이 - 다양한 난이도와 주제별 문제를 풀며 실전 감각을 키울 수 있어요.
강의 지원 - 강의와 연계된 과제 및 실습으로 체계적으로 학습해보세요.

이런 식으로 카드 네개만 보이게 부탁드려요! 텍스트는 제가 그냥 제미나이 돌린 건데 얼마든지 수정하셔도 됩니당. 아이콘도 적절히 어울리는 걸로 배치해주세요~

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

탭 부분은 주석처리하고 말씀하신대로 변경했습니다!

@skkuding-bot
Copy link
Copy Markdown

skkuding-bot Bot commented May 22, 2026

Syncing Preview App Failed

Application: frontend
Revision: 149c2e41b1761355adc68d9b2beda7791e433540
Health Status: Degraded

Open Preview | View in Argo CD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview 이 라벨이 붙어있어야 프론트엔드 Preview 환경이 생성됩니다 ⛳️ team-frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants