CompanyOrSpeakerOrMemberAutocompleteWithDialog component refactored#566
Merged
Francisca105 merged 1 commit intostagingfrom Mar 3, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the CompanySpeakerMemberAutocompleteWithDialog search behavior by extracting the fuzzy-search and ordering logic into a dedicated Vue composable, reducing component complexity and improving reuse.
Changes:
- Added
useCompanySpeakerMemberSearchcomposable to encapsulate fuzzy search, group ordering, and flattened result generation. - Updated
CompanySpeakerMemberAutocompleteWithDialog.vueto use the new composable and removed in-component fuzzy-search implementation. - Updated
Navbar.vueto use the renamed/updated autocomplete component import and tags.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
frontend/src/composables/useCompanySpeakerMemberSearch.ts |
Introduces shared fuzzy-search + group ordering logic for companies/speakers/members. |
frontend/src/components/Navbar.vue |
Switches navbar usage to the CompanySpeakerMemberAutocompleteWithDialog component. |
frontend/src/components/CompanySpeakerMemberAutocompleteWithDialog.vue |
Replaces embedded search logic with the new composable and keeps UI/selection behavior in the component. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Francisca105
deleted the
565-refactor-companyorspeakerormemberautocompletewithdialog
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes the separation of searching logic of this component into a composable