Fix writing to read-only array bug in nerdss_converter.py#208
Open
PhysFoley wants to merge 1 commit intosimularium:mainfrom
Open
Fix writing to read-only array bug in nerdss_converter.py#208PhysFoley wants to merge 1 commit intosimularium:mainfrom
PhysFoley wants to merge 1 commit intosimularium:mainfrom
Conversation
…n overwrite immutable one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a small bug in the NERDSS converter that was causing it to fail due to attempting to write to a read-only numpy array.
Time estimate or Size
xsmall
Problem
NERDSS trajectories were failing to convert to simularium format due to an issue within the NerdssConverter class where it tried to write to elements of a read-only numpy array.
Solution
Create a copy of the numpy array with the same shape, edit this array, then overwrite the original.
Type of change
Change summary:
Steps to Verify:
Keyfiles (delete if not relevant):