Open
Conversation
simonmar
requested changes
Feb 27, 2019
Owner
simonmar
left a comment
simonmar
left a comment
There was a problem hiding this comment.
Thanks! Some of these are OK, others are stylistic changes that I'm not keen on, as noted in the inline comments.
Author
|
Happy to revert the changes that you have identified above. The next task will be to update the networking; a good few usages seem to be deprecated with the recommendation to use |
hazelweakly
reviewed
Mar 3, 2019
|
What's the status of this pull request? |
Author
|
I thought that I'd addressed Simon's comments. Let me know if you need anything more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the book. I wish that I had bought it sooner. It is one of the few programming / haskell books that explains some of the mysteries in a lucid way, while offering insights into the tradeoffs into between the different idioms.
Here's a modicum of hlint refactoring.
The main issue that the software has is that it should move to using the Network.Socket library as the existing network library code is deprecated. An exercise for another day.