Skip to content

Conversation

@GuySartorelli
Copy link
Member

Comment on lines +147 to +158
```yml
Symbiote\QueuedJobs\Services\AbstractQueuedJob:
# Retry pattern with spread
# First retry attempt - Retry after 8 to 12 minutes
# Second retry attempt - Retry after 6.4 to 14.4 minutes
# Third retry attempt - Retry after 5.1 to 27.4 minutes
# Fourth retry attempt - Retry after 4 to 38.4 minutes
retry_max_attempts: 4
retry_initial_delay: 600
retry_falloff_multiplier: 1
retry_falloff_multiplier_variance: 0.2
```
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


### Automatic retries for queued jobs

The [symbiote/silverstripe-queuedjobs](/optional_features/queuedjobs/) module now has the ability to automatically retry broken or paused jobs. By default no jobs will be retried, but you can easily enable this for all jobs by setting [`AbstractQueuedJob.retry_max_attempts`](api:Symbiote\QueuedJobs\Services\AbstractQueuedJob->retry_max_attempts) to the maximum number times you want to retry jobs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The [symbiote/silverstripe-queuedjobs](/optional_features/queuedjobs/) module now has the ability to automatically retry broken or paused jobs. By default no jobs will be retried, but you can easily enable this for all jobs by setting [`AbstractQueuedJob.retry_max_attempts`](api:Symbiote\QueuedJobs\Services\AbstractQueuedJob->retry_max_attempts) to the maximum number times you want to retry jobs.
The [symbiote/silverstripe-queuedjobs](/optional_features/queuedjobs/) module now has the ability to automatically retry broken or paused jobs. By default no jobs will be retried, but you can easily enable this for all jobs by setting [`AbstractQueuedJob.retry_max_attempts`](api:Symbiote\QueuedJobs\Services\AbstractQueuedJob->retry_max_attempts) to the maximum number of times you want to retry jobs.


You can also define the delay between retry attempts, and randomise that delay to prevent clobbering your site and any external services your jobs might connect to.

```yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example given is really confusing in the context of a changelog i.e. people reading (including myself) don't have knowledge of what the PR does so seeing things like Third retry attempt - Retry after 5.1 to 27.4 minutes is confusing based on the given config. I think it would be better to not have this example, say it's configurable and simply link to the docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants