DOC File modal title automatically gets focus#816
Open
emteknetnz wants to merge 1 commit intosilverstripe:6from
Open
DOC File modal title automatically gets focus#816emteknetnz wants to merge 1 commit intosilverstripe:6from
emteknetnz wants to merge 1 commit intosilverstripe:6from
Conversation
emteknetnz
force-pushed
the
pulls/6/modal-focus
branch
from
f13fc2b to
d6f1f8e
Compare
GuySartorelli
requested changes
Sep 25, 2025
|
|
||
| A skip link has been added to the CMS to allow users to skip past the main navigation. This is primarily for users who use a screen reader or who navigate via the keyboard. The link is visually hidden until it receives focus by pressing the tab key. | ||
|
|
||
| #### Other accessibility improvements |
Member
There was a problem hiding this comment.
"other" should be at the bottom of the "accessibility improvements" section
|
|
||
| #### Other accessibility improvements | ||
|
|
||
| - The file modal title now receives focus when opened (e.g. when selecting "Choose existing" from an upload field). |
Member
There was a problem hiding this comment.
If we're going to add this to the changelog it should probably state how this changed - i.e. what did it used to do?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-asset-admin#1022