Sqlx sqlite observer final phase #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- we wrapped SqliteDatabase and WriteGuard and, otherwise implemented seamless interop between observer and conn-mgr
- Previously we were just logging a warning when the number of changes in a tx exceeded the channel capacity. Now we report the lag in the change event to make it more obvious to the user and allow for the user to respond to this "error" condition.
pmorris-dev
force-pushed
the
sqlx-sqlite-observer-final-phase
branch
from
62349ba to
a149af9
Compare
jjhafer
approved these changes
Feb 9, 2026
Contributor
jjhafer
left a comment
jjhafer
left a comment
There was a problem hiding this comment.
Looks good. Claude also didn't find anything wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.