TT-7145 Enhance useWaveSurfer to improve playhead behavior#295
Merged
sarahentzel merged 2 commits intodevelopfrom May 6, 2026
Merged
TT-7145 Enhance useWaveSurfer to improve playhead behavior#295sarahentzel merged 2 commits intodevelopfrom
sarahentzel merged 2 commits intodevelopfrom
Conversation
Contributor
gtryus
commented
May 5, 2026
gtryus
commented
- Introduced a constant FINISH_END_EPSILON_SEC to nudge the playhead slightly before the true duration, ensuring the custom cursor remains visible at the end.
- Updated the playhead logic to clamp the current time within valid duration bounds.
- Modified the 'finish' event handler to safely navigate to the adjusted end time before stopping playback, enhancing user experience.
added 2 commits
May 5, 2026 16:57
- Introduced a constant FINISH_END_EPSILON_SEC to nudge the playhead slightly before the true duration, ensuring the custom cursor remains visible at the end. - Updated the playhead logic to clamp the current time within valid duration bounds. - Modified the 'finish' event handler to safely navigate to the adjusted end time before stopping playback, enhancing user experience.
proposed by devin
sarahentzel
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.