Bump frontend deps (all prod, some dev)#4274
Conversation
📝 WalkthroughWalkthroughThis PR upgrades multiple frontend dependencies including axios, motion, i18next stack, and react-router in package.json, with corresponding license manifest updates. Additionally, the embedded Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4274 +/- ##
=======================================
Coverage 75.94% 75.94%
=======================================
Files 303 303
Lines 11352 11352
Branches 1403 1403
=======================================
Hits 8621 8621
Misses 2330 2330
Partials 401 401
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
package.json (1)
76-76: Add a defensive guard for the privaterouter.subscribeAPI before thereact-routerversion bump.The codebase relies on
router.subscribe()insrc/router/browserRouter.tsx:17for analytics/page navigation. The developers explicitly documented that this is a private API (lines 14–16) and flagged it as needing verification with future react-router updates. With~7.13.2allowing minor patch updates, a router change could break app bootstrap. Wrap the subscribe call with a try-catch or feature detection to ensure the app remains stable even if the private API is removed or changed.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@package.json` at line 76, Wrap the private router.subscribe() call in a defensive guard that detects availability and handles failures: check that the router object and router.subscribe are functions (or use typeof router.subscribe === "function") before calling, and surround the call with a try-catch to log and swallow any errors so bootstrap won’t crash; update the subscribe usage in the browserRouter (the function/module that calls router.subscribe) to use this feature-detection + try-catch pattern and ensure any analytics callback registration failure is safely no-oped.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/user_guide/assets/licenses/frontend_licenses.txt`:
- Around line 1063-1085: The project currently has mixed MUI majors—root
packages like `@mui/private-theming`, `@mui/styled-engine`, `@mui/system`, and
`@mui/utils` at v7.3.10 (pulled in by `@mui/x-date-pickers` v7.29.4) while
`@mui/material` remains at 6.5.0; inspect package.json and the lockfile for the
explicit dependency on `@mui/x-date-pickers` and decide whether to (a) upgrade
`@mui/material` to v7 to align with `@mui/x-date-pickers` v7, (b) downgrade
`@mui/x-date-pickers` to a v6 release to match `@mui/material`, or (c) accept dual
majors and document the trade-offs; then implement the chosen path (update
package.json, run yarn/npm install, and regenerate the lockfile) and, if keeping
mixed versions, add a note in docs mentioning potential theming/context risks
and why `@mui/x-date-pickers` v7 is required.
---
Nitpick comments:
In `@package.json`:
- Line 76: Wrap the private router.subscribe() call in a defensive guard that
detects availability and handles failures: check that the router object and
router.subscribe are functions (or use typeof router.subscribe === "function")
before calling, and surround the call with a try-catch to log and swallow any
errors so bootstrap won’t crash; update the subscribe usage in the browserRouter
(the function/module that calls router.subscribe) to use this feature-detection
+ try-catch pattern and ensure any analytics callback registration failure is
safely no-oped.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 2ab45a71-9eec-46a2-ae1a-1cc330373c47
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
docs/user_guide/assets/licenses/frontend_licenses.txtpackage.json
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on imnasnainaec).
Also dedup to avoid loading in
@mui/x-date-pickers's MUIv7 peer deps.Devin: https://app.devin.ai/review/sillsdev/TheCombine/pull/4274
This change is
Summary by CodeRabbit