Skip to content

[ansible] Enable NUC user kubectl access#4273

Merged
imnasnainaec merged 1 commit into
masterfrom
bugfix/nuc-install-kubectl-perm
May 1, 2026
Merged

[ansible] Enable NUC user kubectl access#4273
imnasnainaec merged 1 commit into
masterfrom
bugfix/nuc-install-kubectl-perm

Conversation

@imnasnainaec
Copy link
Copy Markdown
Collaborator

@imnasnainaec imnasnainaec commented Apr 30, 2026

After installing The Combine on a NUC, attempts to run kubectl get pods on the NUC user's cli result in:

WARN[0000] Unable to read /etc/rancher/k3s/k3s.yaml, please start server with --write-kubeconfig-mod to modify kube config permissions
error: error loading config file "/etc/rancher/k3s/k3s.yaml": open /etc/rancher/k3s/k3s.yaml: permission denied

The temporary fix is export KUBECONFIG=$HOME/.kube/config. This pr is the permanent fix.

It seams older k3s installers weren't so strict and would silently fall back to this path.

Devin: https://app.devin.ai/review/sillsdev/TheCombine/pull/4273


This change is Reviewable

Summary by CodeRabbit

  • Bug Fixes
    • Fixed an issue where profile configuration updates were not consistently applied across all deployment connection types during Kubernetes installation.

@imnasnainaec imnasnainaec self-assigned this Apr 30, 2026
@imnasnainaec imnasnainaec added bug Something isn't working 🟨Medium Medium-priority PR labels Apr 30, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 30, 2026

📝 Walkthrough

Walkthrough

The update profile task in the Kubernetes installation Ansible role has its connection type conditional removed, allowing it to execute on all connection types rather than only local connections.

Changes

Cohort / File(s) Summary
Kubernetes Installation Configuration
deploy/ansible/roles/k8s_install/tasks/main.yml
Removed conditional when: ansible_connection == "local" from the update profile task, enabling it to run regardless of Ansible connection type while maintaining the same functionality of writing KUBECONFIG export to user profile.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

deployment

Suggested reviewers

  • jasonleenaylor
  • myieye

Poem

🐰 A condition removed with a flick of the pen,
Now the profile updates again and again,
No "local" needed, it spreads far and wide,
KUBECONFIG flows with unbounded pride! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: enabling kubectl access for the NUC user by removing a conditional that was preventing the profile update from running.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bugfix/nuc-install-kubectl-perm

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.94%. Comparing base (a7bf167) to head (5ab832d).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4273   +/-   ##
=======================================
  Coverage   75.94%   75.94%           
=======================================
  Files         303      303           
  Lines       11352    11352           
  Branches     1403     1403           
=======================================
  Hits         8621     8621           
  Misses       2330     2330           
  Partials      401      401           
Flag Coverage Δ
backend 87.23% <ø> (ø)
frontend 66.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jasonleenaylor reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on imnasnainaec).

@imnasnainaec imnasnainaec merged commit fe9a402 into master May 1, 2026
23 checks passed
@imnasnainaec imnasnainaec deleted the bugfix/nuc-install-kubectl-perm branch May 1, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working deployment 🟨Medium Medium-priority PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants