docs(menu): improve and extend example#1675
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request extends the documentation examples for si-menu to demonstrate various trigger methods, including default buttons, tertiary buttons, and context menus. The changes are a good improvement to the documentation. I've left a few minor suggestions to improve consistency in the documentation headings and to clean up some extraneous whitespace in the HTML examples.
spike-rabbit
left a comment
spike-rabbit
left a comment
There was a problem hiding this comment.
I like the new example. @panch1739 any opinions?
@robertwilde please squash all your commits into one and please drop the si- prefix from the message: docs(menu): ...
@spike-rabbit @robertwilde this is great! We wanted to improve the examples for some time :) I just have one observation, maybe the tertiary button should be the square variant instead of the circle, since that is our default. But otherwise perfect! |
robertwilde
force-pushed
the
docs/si-menu/improve-example
branch
from
9abb032 to
91d8c65
Compare
robertwilde
changed the title
robertwilde
force-pushed
the
docs/si-menu/improve-example
branch
from
91d8c65 to
ff703e0
Compare
3 participants
Closes #984
Introduce 3 columns to trigger the menu in both declarative and factory example.
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: