Conversation
…re a common prefix Co-authored-by: shibayan <1356444+shibayan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix error in single selection from string array
Fix Select prompt failing to accept exact match when items share a common prefix
Feb 26, 2026
Owner
|
@copilot Please resolve conflicts |
… new tests Co-authored-by: shibayan <1356444+shibayan@users.noreply.github.com>
Contributor
Author
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a Sharprompt Select prompt edge case where typing a filter that exactly matches an item (case-insensitive) fails to allow selection when other items share the same prefix (e.g., Select vs SelectWithEnum).
Changes:
- Update
Paginator.TryGetSelectedItemto auto-select an exact (case-insensitive) match ofFilterKeywordeven when multiple filtered items exist. - Add unit tests covering exact match, case-insensitive exact match, and no exact match scenarios.
- Resolve test merge conflicts in
PaginatorTests.csand keep the suite passing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Sharprompt/Internal/Paginator.cs | Adds exact-match selection fallback when no explicit selection exists. |
| Sharprompt.Tests/PaginatorTests.cs | Adds regression tests for exact-match auto-selection behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shibayan
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paginator.TryGetSelectedItemto auto-select an item when the filter keyword is an exact (case-insensitive) match, even if other items also contain the keyword as a substringOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.