Conversation
This commit should have zero functional changes, but remove the no longer expected space between a function and its arguments. Signed-off-by: Pat Riehecky <riehecky@fnal.gov>
alejandro-colomar
requested review from
alejandro-colomar,
hallyn and
ikerexxe
and removed request for
hallyn and
ikerexxe
|
The problem with such a huge patch would be that downstream is going to have problems rebasing patches. But I'm fine with this, FWIW. (I haven't reviewed yet, but the idea seems reasonable.) |
|
BTW, if this has been scripted, please paste the scripts in the commit message, so that it can be fully reproduced and investigated. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| printf (MSG_WARN_EDIT_OTHER_FILE, | ||
| pw_dbname (), | ||
| spw_dbname (), | ||
| vipwedit(pw_dbname(), pw_lock, pw_unlock); |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
| db->changed = false; | ||
|
|
||
| fd = open (db->filename, | ||
| fd = open(db->filename, |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
| } | ||
|
|
||
| tp = localtime (&(fail->fail_time)); | ||
| tp = localtime(&(fail->fail_time)); |
Check failure
Code scanning / CodeQL
Use of potentially dangerous function Critical
| * grief. | ||
| */ | ||
| (void) execle (file, arg, (char *) NULL, envp); | ||
| (void) execle(file, arg, (char *) NULL, envp); |
Check failure
Code scanning / CodeQL
Uncontrolled process operation High
| printf (MSG_WARN_EDIT_OTHER_FILE, | ||
| spw_dbname (), | ||
| pw_dbname (), | ||
| vipwedit(spw_dbname(), spw_lock, spw_unlock); |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
| continue; | ||
| } | ||
| if (set_locktime_one (pwent->pw_uid, locktime)) { | ||
| if (set_locktime_one(pwent->pw_uid, locktime)) { |
Check warning
Code scanning / CodeQL
Potential exposure of sensitive system data to an unauthorized control sphere Medium
| continue; | ||
| } | ||
| if (setmax_one (pwent->pw_uid, max)) { | ||
| if (setmax_one(pwent->pw_uid, max)) { |
Check warning
Code scanning / CodeQL
Potential exposure of sensitive system data to an unauthorized control sphere Medium
| continue; | ||
| } | ||
| if (reset_one (pwent->pw_uid)) { | ||
| if (reset_one(pwent->pw_uid)) { |
Check warning
Code scanning / CodeQL
Potential exposure of sensitive system data to an unauthorized control sphere Medium
| @@ -2056,7 +2056,7 @@ | |||
| } | |||
| #endif /* ENABLE_LASTLOG */ | |||
|
|
|||
| static void tallylog_reset (const char *user_name) | |||
| static void tallylog_reset(const char *user_name) | |||
Check notice
Code scanning / CodeQL
Local variable hides global variable Note
2 participants
This commit should have zero functional changes, but remove the no longer expected space between a function and its arguments.